markt-asf commented on code in PR #628:
URL: https://github.com/apache/tomcat/pull/628#discussion_r1238933690
##########
webapps/host-manager/css/manager.css:
##########
@@ -125,6 +132,16 @@ TD {
vertical-align: middle;
font-family : sans-serif, Tahoma, Arial;
color : black;
+ padding : 5px;
+ color : #636363;
Review Comment:
Switching from Black to Grey reduces the contrast and makes it harder to
read. I think it would be better left as black. It is also odd to have the
titles stand out less than the content.
##########
webapps/host-manager/css/manager.css:
##########
@@ -138,4 +155,59 @@ form.inline {
img.tomcat-logo {
height: 92px;
float : left;
-}
\ No newline at end of file
+}
+
+input[type="submit" i] {
+ appearance: none;
+ background-color: #FAFBFC;
+ border: 1px solid rgba(27, 31, 35, 0.15);
+ border-radius: 6px;
+ box-shadow: rgba(27, 31, 35, 0.04) 0 1px 0, rgba(255, 255, 255, 0.25) 0
1px 0 inset;
+ box-sizing: border-box;
+ color: #24292E;
+ cursor: pointer;
+ display: inline-block;
+ font-size: 14px;
+ font-weight: 500;
+ line-height: 20px;
+ list-style: none;
+ padding: 6px 16px;
+ position: relative;
+ transition: background-color 0.2s cubic-bezier(0.3, 0, 0.5, 1);
+ user-select: none;
+ -webkit-user-select: none;
+ touch-action: manipulation;
+ vertical-align: middle;
+ white-space: nowrap;
+ word-wrap: break-word;
+}
+
+input[type="submit" i]:hover {
+ background-color: #F3F4F6;
+ text-decoration: none;
+ transition-duration: 0.1s;
+}
+
+input[type="submit" i]:active {
+ background-color: #EDEFF2;
+ box-shadow: rgba(225, 228, 232, 0.2) 0 1px 0 inset;
+ transition: none 0s;
+}
+
Review Comment:
You have trailing spaces on this line that need to be removed. If you run
the build with Checkstyle enabled it will find any issues like this.
##########
webapps/manager/css/manager.css:
##########
@@ -125,6 +132,16 @@ TD {
vertical-align: middle;
font-family : sans-serif, Tahoma, Arial;
color : black;
+ padding : 5px;
+ color : #636363;
Review Comment:
Same as above.
##########
webapps/manager/css/manager.css:
##########
@@ -138,4 +155,59 @@ form.inline {
img.tomcat-logo {
height: 92px;
float : left;
-}
\ No newline at end of file
+}
+
+input[type="submit" i] {
+ appearance: none;
+ background-color: #FAFBFC;
+ border: 1px solid rgba(27, 31, 35, 0.15);
+ border-radius: 6px;
+ box-shadow: rgba(27, 31, 35, 0.04) 0 1px 0, rgba(255, 255, 255, 0.25) 0
1px 0 inset;
+ box-sizing: border-box;
+ color: #24292E;
+ cursor: pointer;
+ display: inline-block;
+ font-size: 14px;
+ font-weight: 500;
+ line-height: 20px;
+ list-style: none;
+ padding: 6px 16px;
+ position: relative;
+ transition: background-color 0.2s cubic-bezier(0.3, 0, 0.5, 1);
+ user-select: none;
+ -webkit-user-select: none;
+ touch-action: manipulation;
+ vertical-align: middle;
+ white-space: nowrap;
+ word-wrap: break-word;
+}
+
+input[type="submit" i]:hover {
+ background-color: #F3F4F6;
+ text-decoration: none;
+ transition-duration: 0.1s;
+}
+
+input[type="submit" i]:active {
+ background-color: #EDEFF2;
+ box-shadow: rgba(225, 228, 232, 0.2) 0 1px 0 inset;
+ transition: none 0s;
+}
+
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
