Han,
On 5/20/23 21:42, Han Li wrote:
On May 21, 2023, at 01:19, Mark Thomas <ma...@apache.org> wrote:
On 19/05/2023 04:24, li...@apache.org <mailto:li...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
lihan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
<https://gitbox.apache.org/repos/asf/tomcat.git>
The following commit(s) were added to refs/heads/main by this push:
new 10492dd22b Clear SocketWrapper reference to help GC
10492dd22b is described below
commit 10492dd22bd64ff63cf77786fa67d45cdc2a54b3
Author: lihan <li...@apache.org <mailto:li...@apache.org>>
AuthorDate: Fri May 19 11:24:27 2023 +0800
Clear SocketWrapper reference to help GC
-1. Veto.
---
java/org/apache/coyote/AbstractProcessor.java | 3 +++
java/org/apache/coyote/http11/Http11Processor.java | 1 -
java/org/apache/coyote/http2/StreamProcessor.java | 6 +-----
The above changes need to be reverted since they break AJP connections. The AJP
processor is recycled after CPING MESSAGES and expects processing to continue
afterwards. Setting the SocketWrapper to null triggers NPEs when trying to
process the request that follows the CPING.
Sigh, I indeed forgot to test the AJP processor.
Have reverted, thanks for the review.
This could be fixed by dropping the AJP connector in Tomcat 11.x :)
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
