This is an automated email from the ASF dual-hosted git repository.
rjung pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new e71864670e Add error logging to failing unit test as a workaround for
missing access to unit test detail log.
e71864670e is described below
commit e71864670e7df50785641a8092b0d2793b4488ee
Author: Rainer Jung <[email protected]>
AuthorDate: Thu Apr 27 22:14:55 2023 +0200
Add error logging to failing unit test
as a workaround for missing access to unit test detail log.
---
test/org/apache/catalina/valves/TestAccessLogValve.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/org/apache/catalina/valves/TestAccessLogValve.java
b/test/org/apache/catalina/valves/TestAccessLogValve.java
index 98bf1bca6d..d6aea92f1e 100644
--- a/test/org/apache/catalina/valves/TestAccessLogValve.java
+++ b/test/org/apache/catalina/valves/TestAccessLogValve.java
@@ -157,6 +157,7 @@ public class TestAccessLogValve extends TomcatBaseTest {
valve.setPattern(logPattern);
tomcat.getHost().getPipeline().addValve(valve);
} else {
+ log.error("Unknown AccessLogValve type " + type);
Assert.fail("Unknown AccessLogValve type " + type);
}
@@ -180,6 +181,9 @@ public class TestAccessLogValve extends TomcatBaseTest {
}
String result = writer.toString();
boolean matches = Pattern.matches(resultMatch, result);
+ if (!matches) {
+ log.error("Resulting log line '" + result + "' does not match '" +
resultMatch + "'");
+ }
Assert.assertTrue("Resulting log line '" + result + "' does not match
'" + resultMatch + "'", matches);
if (JSON_TYPE.equals(type)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
