On Thu, Apr 27, 2023 at 6:34 PM Mark Thomas <ma...@apache.org> wrote: > > Hi all, > > As part of a discussion around a Spring Boot issue [1], the question has > been raised whether there is merit in moving the Utility executor > start/stop from StandardServer init/destroy to start/stop. > > I've looked at the code and I don't see any uses of the Executor until > sub-components are in the start phase (there is a little copying of > references that might need to move) so I think the change is doable. > > The main advantage is that in the embedded scenario where there might be > a long series of start / stop / start / stop etc, shutting down the > executor on stop should avoid issues where executor tasks are not > shutdown correctly. My brief code review suggested that Tomcat does this > correctly but the executor is also exposed to application code. > > Thoughts?
I think I put it here in case there would be utility tasks to do on init, but that's probably not a good design. So you can try to move it, and see if something breaks ;) Rémy > > Mark > > [1] https://github.com/spring-projects/spring-boot/issues/34955 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
