This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 8f08e13b9d Update false positives
8f08e13b9d is described below
commit 8f08e13b9d2b0fd10bba8d1513ff84a3f12a2c57
Author: Mark Thomas <[email protected]>
AuthorDate: Thu Apr 13 15:08:56 2023 +0100
Update false positives
---
res/spotbugs/filter-false-positives.xml | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml
b/res/spotbugs/filter-false-positives.xml
index 90429a9ec2..68a5b2d346 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -2670,6 +2670,24 @@
<Field name="data"/>
<Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY"/>
</Match>
+ <Match>
+ <!-- Statics are used deliberately as they are simpler -->
+ <Class name="org.apache.tomcat.websocket.server.TestClose" />
+ <Method name="setUp" />
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+ </Match>
+ <Match>
+ <!-- Statics are used deliberately as they are simpler -->
+ <Class
name="org.apache.tomcat.websocket.server.TestWsRemoteEndpointImplServerDeadlock"
/>
+ <Method name="testTemporaryDeadlockOnClientClose" />
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+ </Match>
+ <Match>
+ <!-- Statics are used deliberately as they are simpler -->
+ <Class
name="org.apache.tomcat.websocket.server.TestWsRemoteEndpointImplServerDeadlock$Bug66508Endpoint"
/>
+ <Method name="onOpen" />
+ <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
+ </Match>
<Match>
<!-- Return value of latch is intentionally ignored -->
<Or>
@@ -2679,12 +2697,6 @@
<Method name="testConnectToServerEndpoint"/>
<Bug pattern="RV_RETURN_VALUE_IGNORED"/>
</Match>
- <Match>
- <!-- Statics are used deliberately as they are simpler -->
- <Class name="org.apache.tomcat.websocket.server.TestClose" />
- <Method name="setUp" />
- <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>
- </Match>
<Match>
<!-- Statics are used deliberately as they are simpler -->
<Class
name="org.apache.tomcat.websocket.TestWsSubprotocols$SubProtocolsEndpoint" />
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
