Mark,

On 4/11/23 06:42, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
      new a788852f6b Improve messages if JAVA_HOME / JRE_HOME not set correctly
a788852f6b is described below

commit a788852f6b48e100bd505dcf7b5633a04f649e7b
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Apr 11 11:41:55 2023 +0100

     Improve messages if JAVA_HOME / JRE_HOME not set correctly
---
  bin/setclasspath.sh        | 24 +++++++++++++++++++++---
  webapps/docs/changelog.xml |  6 ++++++
  2 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/bin/setclasspath.sh b/bin/setclasspath.sh
index b81bc197d1..f56b2aa473 100755
--- a/bin/setclasspath.sh
+++ b/bin/setclasspath.sh
@@ -53,15 +53,13 @@ if [ -z "$JAVA_HOME" ] && [ "$1" = "debug" ]; then
    echo "JAVA_HOME should point to a JDK in order to run in debug mode."
    exit 1
  fi
-if [ -z "$JRE_HOME" ]; then
-  JRE_HOME="$JAVA_HOME"
-fi
# If we're running under jdb, we need a full jdk.
  if [ "$1" = "debug" ] ; then
    if [ "$os400" = "true" ]; then
      if [ ! -x "$JAVA_HOME"/bin/java ] || [ ! -x "$JAVA_HOME"/bin/javac ]; then
        echo "The JAVA_HOME environment variable is not defined correctly"
+      echo "JAVA_HOME=$JAVA_HOME"
        echo "This environment variable is needed to run this program"
        echo "NB: JAVA_HOME should point to a JDK not a JRE"

I think this message is no longer accurate, right? ^^^

AIUI, Tomcat can use a JRE ever since we started bundling the Eclipse compiler for JSPs.

-chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to