Re: [GitHub] [tomcat] markt-asf opened a new pull request, #606: Further fix for BZ 66508

[Mark Thomas]

On 28/03/2023 07:44, markt-asf (via GitHub) wrote:

markt-asf opened a new pull request, #606:
URL: https://github.com/apache/tomcat/pull/606

    https://bz.apache.org/bugzilla/show_bug.cgi?id=66508

I'd really like to get this fixed for the April releases but the fix is 
non-trivial. Review would be very welcome.

I have some ideas for a unit test that I'll try and get to later this week.

Mark


    
    Avoid deadlock for close messages when
    WsRemoteEndpointImplServer.endMessage() for a previous message is processed 
on a container thread
    
    The fix for this involves the thread currently processing a socket effectively yielding the socket lock and processor to another thread. I think that is worthy of closer review before merge.
    
    There are a couple of potential alternatives.
    
    Plan B would be to make handing of the close message async. That is potentially better but will be more complex to implement and may uncover other complexities.
    
    Plan C would be to require useAsyncIO="true" to enable WebSocket.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org