On 07/03/2023 08:24, Han Li wrote:
Hi Mark,Remy and Konstatntin,

Thank you for such detailed answers, I read all your reply in full. I read, and 
the reason for this commit is because of user feedback about a bug, see below:
https://github.com/apache/tomcat/pull/595 
<https://github.com/apache/tomcat/pull/595>

And then I found that it was inconsistent with the spec, in my realize, the 
Jakarta package in the tomcat project should be aligned with the spec (which is 
obviously wrong so far),
So I just simply copied and pasted it and committed it.

According to the reply, I found that I just need to follow the PR’s change to 
submit without doing anything extra.

Correct.

This is a good example of an implementation difference.

The specification provides an error message that the request and/or response are not of the right type but does not specify which is(are) wrong. Tomcat provides a specific error message that tells you which one is wrong.

Both approaches are valid. I'd argue Tomcat's is a little better - but I would wouldn't I ;)

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to