Rainer Jung wrote:
1) Things to add to the changelog =================================
I added few. Some of them are waste of resource IMHO ;)
I found the following changes, which are missing in the change log. Not all of them need to go there, but maybe Mladen, Jean-Frederic, Guenter and Henri can check, which ones they did and maybe add a line to the change log: - Fix html syntax in news docs pages - jkrelease.sh: new users root:bin, automate file list for NEWS, compress with gtar, don't set ANT_HOME and JAVA_HOME - New build files on Win (nmake) - Add tc 6 examples to config example and iis config example uriworkermap. - apache: rename file_logger_t to jk_file_logger_t - logging: refactor line endings logging to make it correct for all platforms and webservers - apache 1.3: rename child exit handler and add shm close - apache 1.3: new child init handler with shm attach - apache: add info level message during mod_jk startup with version info - apache 2.2: win build env var APACHE22 und APACHE22_HOME and correct apr/apr-1 distinction - Fix whitespace in Netware make file - Updates to iSeries Make file - apache 2.0: use plog instead of pconf when initializing loggers - Use fputs instead of fwrite in logging - Translate charsets when dumping buffers and using EBCDIC - Add worker names to some log messages in jk_ajp_common.c 2) Missing subversion properties corrected ========================================== I added subversion properties svn:eol-style native svn:keywords 'Author Date Id Revision' to the following win files, which had no props at all: jk/native/iis/pcre/pcre.amd64 jk/native/iis/pcre/pcre.ia64 jk/native/iis/pcre/dftables.x86 jk/native/iis/pcre/pcre.x86 jk/native/iis/Makefile.ia64 jk/native/iis/Makefile.x86 jk/native/iis/Makefile.amd64
Should have eol:native, thanks.
No all line endings should be platform native. I hope that's correct.
Sure, like all textual contents.
The other files with no properties were all binaries (*.exe, *.gif, *.ico, *.rtf). More precisely, I fixed a couple of non-IIS files, and now the remaining ones are only binary formats.
Perfect.
3) fail_on_status =================
Made that multi line.
4) load_properties/load_property ================================
If that makes you happy, I'm sure they can be merged ;)
5) Reference links on NEWS file =============================== The NEWS file contains links of the form in the reference section file:///home/mturk/wrkplace/tomcat-connectors-1.1.22-dev-524775-src/
This is wrong links usage. Think it has the no reference option. I'll investigate and update jkrelease.sh
7) Missing docs =============== Mladen, maybe you can add a few lines to the two IIS docs pages about the new cool URL rewriting? Or do you want to release the new feature in stealth mode and document in 1.2.23?
Have no time for documentation right now. Nevertheless, it can be added later. There is no need to be the part of the package itself. IMHO the one that counts is on the tomcat.apache.org site.
9) JK_SHM_LOCK_REOPEN ===================== What's the use of JK_SHM_LOCK_REOPEN?
Something no one will ever use I hope ;) On some kernels the flock was failing if inherited from parent, but that is kernel bug, not ours. To fight with that we by default use fcntl, that BTW allows to have the locks on NFS shares as well. For those that wish tho experiment there is configure --enable-flock if you know your locks won't be on the NFS share and don't have buggy kernel. In general JK_SHM_REOPEN was added to prove the kernel bug, but since it's a hack and security leach it'll go away. IMHO it is of developers interest only. Regards, Mladen. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]