[tomcat] 02/02: Additional false positives when running via Ant

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 3737dd8f7c5941fb19f221278fda726a31c39ab7
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Jan 6 15:52:28 2023 +0000

    Additional false positives when running via Ant
---
 res/spotbugs/filter-false-positives.xml | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/res/spotbugs/filter-false-positives.xml 
b/res/spotbugs/filter-false-positives.xml
index 8405047bc8..7a18f5fbdf 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -954,6 +954,16 @@
     <Method name="emitHeader" />
     <Bug pattern="VO_VOLATILE_INCREMENT" />
   </Match>
+  <Match>
+    <!-- False positive. Affects 4.7.3. May affect other versions. -->
+    <Class name="org.apache.coyote.http2.HpackDecoder" />
+    <Method name="handleMaxMemorySizeChange" />
+    <Or>
+      <Field name="currentMemorySize" />
+      <Field name="filledTableSlots" />
+    </Or>
+    <Bug pattern="SA_FIELD_SELF_ASSIGNMENT" />
+  </Match>
   <Match>
     <!-- Number being tested is unsigned. -->
     <Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
@@ -972,6 +982,12 @@
     <Method name="incrementWindowSize" />
     <Bug pattern="NN_NAKED_NOTIFY" />
   </Match>
+  <Match>
+    <!-- Switch fall-through is intentional. -->
+    <Class name="org.apache.coyote.http2.Http2UpgradeHandler" />
+    <Method name="upgradeDispatch" />
+     <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+  </Match>
   <Match>
     <!-- Return value is intentionally ignored. -->
     <Class name="org.apache.coyote.http2.Http2UpgradeHandler$PingManager" />
@@ -1422,6 +1438,12 @@
     <Method name="toString"/>
     <Bug code="NP" />
   </Match>
+  <Match>
+    <!-- Switch fall-through is intentional. -->
+    <Class name="org.apache.tomcat.util.buf.MessageBytes"/>
+    <Method name="toChars"/>
+    <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+  </Match>
   <Match>
     <!-- Returning null here is fine -->
     <Class name="org.apache.tomcat.util.buf.MessageBytes"/>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org