This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit dbeb4f2602c683460f78550f857a20f09099a86a
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Fri Jan 6 15:37:19 2023 +0000
Fix SpotBugs issues reported via IDE
---
res/spotbugs/filter-false-positives.xml | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml
b/res/spotbugs/filter-false-positives.xml
index b2710b9dca..2f9ee2ca8a 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -1208,15 +1208,15 @@
</Match>
<Match>
<!-- SQL construction is necessary for pooled statements -->
+ <Class name="org.apache.tomcat.dbcp.dbcp2.PStmtKey" />
<Or>
- <Class name="org.apache.tomcat.dbcp.dbcp2.PStmtKey$PreparedStatementSQL"
/>
- <Class
name="org.apache.tomcat.dbcp.dbcp2.PStmtKey$PreparedStatementWithAutoGeneratedKeys"
/>
- <Class
name="org.apache.tomcat.dbcp.dbcp2.PStmtKey$PreparedStatementWithColumnIndexes"
/>
- <Class
name="org.apache.tomcat.dbcp.dbcp2.PStmtKey$PreparedStatementWithColumnNames" />
- <Class
name="org.apache.tomcat.dbcp.dbcp2.PStmtKey$PreparedStatementWithResultSetConcurrency"
/>
- <Class
name="org.apache.tomcat.dbcp.dbcp2.PStmtKey$PreparedStatementWithResultSetHoldability"
/>
+ <Method name="lambda$3" />
+ <Method name="lambda$4" />
+ <Method name="lambda$5" />
+ <Method name="lambda$6" />
+ <Method name="lambda$7" />
+ <Method name="lambda$8" />
</Or>
- <Method name="createStatement" />
<Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" />
</Match>
<Match>
@@ -2458,6 +2458,12 @@
</Or>
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT" />
</Match>
+ <Match>
+ <!-- NPE here is OK - it signals the test isn't configured correctly -->
+ <Class
name="org.apache.tomcat.util.http.parser.TesterHttpWgStructuredField" />
+ <Method name="doTestDirectory" />
+ <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE" />
+ </Match>
<Match>
<!-- Object not used as this is a performance test -->
<Class name="org.apache.tomcat.util.http.TesterParametersPerformance" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
