https://bz.apache.org/bugzilla/show_bug.cgi?id=66392
--- Comment #2 from Michael Osipov <micha...@apache.org> --- (In reply to Han Li from comment #1) > (In reply to Michael Osipov from comment #0) > > May java.nio.charset.Charset.defaultCharset() would be better here, no? > No, I found the reason why not use java.nio.charset.Charset.defaultCharset() > by git commit log. > https://github.com/apache/tomcat/commit/ > 972212836bf278e443b87418d961d6ddb04262a6 > > I also have a question based on the comment at BZ51408, is it time to use > UTF-8 as the default encoding set now? Looking that the commit, in several spots US-ASCII would be a better choice because the usecase does not allow anything else but 7-bit chars. In this case, yes I'd prefer UTF-8 all the way -- at least the documentation and code must be consistent. E.g., here https://github.com/apache/tomcat/commit/972212836bf278e443b87418d961d6ddb04262a6#diff-95ff2368b8571e4f1439f6a6c954993bd9a1de99e7083b9f0c07bb39af7382a2R100. US-ASCII is fully sufficient. Similar case: https://github.com/apache/httpcomponents-core/pull/375 -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
