DanielThomas commented on code in PR #36:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601
##########
src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java:
##########
@@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes,
EESpecProfile profile) {
if (attributes.containsKey(Attributes.Name.IMPLEMENTATION_VERSION)) {
String newValue =
attributes.get(Attributes.Name.IMPLEMENTATION_VERSION) + "-" +
Info.getVersion();
attributes.put(Attributes.Name.IMPLEMENTATION_VERSION, newValue);
- result = true;
+ // Purposefully avoid setting result
Review Comment:
This is metadata and would cause every file with an implementation version
attribute (which is practically everything) to be considered converted, even if
no interesting conversions took place. The destination manifest is written
regardless with this change, so this doesn't prevent the updated implementation
version from hitting the destination file. Omitting this is what allows
`hasConverted()` to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
