[tomcat] branch 8.5.x updated: Refactor. Using List interface so use ArrayList rather than LinkedList

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new b0c1eff131 Refactor. Using List interface so use ArrayList rather than 
LinkedList
b0c1eff131 is described below

commit b0c1eff131f2bc23c6135e9dcc8076849bf77a5a
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Wed Oct 5 18:08:17 2022 +0100

    Refactor. Using List interface so use ArrayList rather than LinkedList
---
 java/org/apache/catalina/filters/CorsFilter.java       | 5 ++---
 java/org/apache/catalina/filters/RemoteCIDRFilter.java | 3 +--
 java/org/apache/catalina/realm/CombinedRealm.java      | 4 ++--
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/java/org/apache/catalina/filters/CorsFilter.java 
b/java/org/apache/catalina/filters/CorsFilter.java
index 201731567e..ef0ca6f065 100644
--- a/java/org/apache/catalina/filters/CorsFilter.java
+++ b/java/org/apache/catalina/filters/CorsFilter.java
@@ -17,12 +17,11 @@
 package org.apache.catalina.filters;
 
 import java.io.IOException;
-import java.net.URI;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashSet;
-import java.util.LinkedList;
 import java.util.List;
 import java.util.Locale;
 import java.util.Set;
@@ -316,7 +315,7 @@ public class CorsFilter implements Filter {
         // Section 6.2.4
         String accessControlRequestHeadersHeader = request.getHeader(
                 CorsFilter.REQUEST_HEADER_ACCESS_CONTROL_REQUEST_HEADERS);
-        List<String> accessControlRequestHeaders = new LinkedList<>();
+        List<String> accessControlRequestHeaders = new ArrayList<>();
         if (accessControlRequestHeadersHeader != null &&
                 !accessControlRequestHeadersHeader.trim().isEmpty()) {
             String[] headers = 
accessControlRequestHeadersHeader.trim().split(",");
diff --git a/java/org/apache/catalina/filters/RemoteCIDRFilter.java 
b/java/org/apache/catalina/filters/RemoteCIDRFilter.java
index ccd76e51ef..ed56e7c6e1 100644
--- a/java/org/apache/catalina/filters/RemoteCIDRFilter.java
+++ b/java/org/apache/catalina/filters/RemoteCIDRFilter.java
@@ -22,7 +22,6 @@ import java.net.InetAddress;
 import java.net.UnknownHostException;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.LinkedList;
 import java.util.List;
 
 import javax.servlet.FilterChain;
@@ -220,7 +219,7 @@ public final class RemoteCIDRFilter extends FilterBase {
             return Collections.emptyList();
         }
 
-        final List<String> messages = new LinkedList<>();
+        final List<String> messages = new ArrayList<>();
         NetMask nm;
 
         for (final String s : input.split("\\s*,\\s*")) {
diff --git a/java/org/apache/catalina/realm/CombinedRealm.java 
b/java/org/apache/catalina/realm/CombinedRealm.java
index e0b82b375b..dc2c23eaa5 100644
--- a/java/org/apache/catalina/realm/CombinedRealm.java
+++ b/java/org/apache/catalina/realm/CombinedRealm.java
@@ -18,8 +18,8 @@ package org.apache.catalina.realm;
 
 import java.security.Principal;
 import java.security.cert.X509Certificate;
+import java.util.ArrayList;
 import java.util.Iterator;
-import java.util.LinkedList;
 import java.util.List;
 
 import javax.management.ObjectName;
@@ -50,7 +50,7 @@ public class CombinedRealm extends RealmBase {
     /**
      * The list of Realms contained by this Realm.
      */
-    protected final List<Realm> realms = new LinkedList<>();
+    protected final List<Realm> realms = new ArrayList<>();
 
     /**
      * Descriptive information about this Realm implementation.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org