On 15/09/2022 22:37, Christopher Schultz wrote:
Mark,
On 9/15/22 11:26, Mark Thomas wrote:
On 15/09/2022 16:23, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 00cf721f14 Refactor to avoid use of Hashtable. No
functional change.
00cf721f14 is described below
commit 00cf721f14ac90e7ebc372a5303603ca408fc999
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Sep 15 16:23:49 2022 +0100
Refactor to avoid use of Hashtable. No functional change.
Any objections to back-porting this?
It changes some protected API for the CGIServlet inner classes (and
the CGI Servlet is final). That seems pretty low risk to me.
I haven't read through the whole class, but is there any risk of
multi-threaded access?
I don't believe so.
At what point is "shellEnv" stable?
Servlet initialisation.
Can it be wrapped in Collections.unmodifiableMap() at any point?
It could at the end of init(ServletConfig).
Can that be added to any other instances of Map<> usage in this class?
Yes.
I'm in two minds whether to use Collections.unmodifiableMap(). It makes
the intended usage clearer (good) but it isn't necessary (bad) since the
Maps aren't exposed to applications.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
