DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=42002>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42002 Summary: Error when no JkWorkersFile used (JK 1.2.21) Product: Tomcat 5 Version: Unknown Platform: All OS/Version: Linux Status: NEW Severity: regression Priority: P2 Component: Native:JK AssignedTo: tomcat-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] Hi, As I upgraded from 1.2.19 to 1.2.21, I hit the following regression : a Wrong [emerg] "Error in reading worker properties" is thrown because I don't have any JkWorkersFile defined. mod_jk.c should silently accept this, while the second part of test about empty map looks correct. I suggest following fix (wich works for me but may need more test) : --- mod_jk.c.orig 2007-02-26 20:09:41.000000000 +0100 +++ mod_jk.c 2007-03-30 22:47:31.000000000 +0200 @@ -2658,17 +2658,16 @@ jk_set_worker_def_cache_size(mpm_threads); /* if(map_alloc(&init_map)) { */ - if (!jk_map_read_properties(init_map, conf->worker_file, NULL, 1, conf->log)) { - if (jk_map_size(init_map) == 0) { - ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_CRIT, - 0, NULL, - "No worker file and no worker options in httpd.conf" - "use JkWorkerFile to set workers"); - } + if ((conf->worker_file!=NULL) && !jk_map_read_properties(init_map, conf->worker_file, NULL, 1, conf->log)) { ap_log_error(APLOG_MARK, APLOG_EMERG | APLOG_NOERRNO, 0, NULL, "Error in reading worker properties"); return !OK; } - + if (jk_map_size(init_map) == 0) { + ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_CRIT, + 0, NULL, + "No worker file and no worker options in httpd.conf" + "use JkWorkerFile to set workers"); + } if (jk_map_resolve_references(init_map, "worker.", 1, 1, conf->log) == JK_FALSE) { ap_log_error(APLOG_MARK, APLOG_EMERG | APLOG_NOERRNO, 0, NULL, "Error in resolving configuration references"); return !OK; -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
