Hi Chris, My x10 dropping it was on java 17.
Romain Le ven. 26 août 2022 à 02:39, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Mark, > > On 8/22/22 07:54, Mark Thomas wrote: > > On 22/08/2022 11:48, Mark Thomas wrote: > >> On 22/08/2022 10:20, Romain Manni-Bucau wrote: > > > > <snip/> > > > >>> So overall I wonder if this check can be dropped now we have concurrent > >>> classloaders and cache almost everywhere. If not, should the missed > >>> items > >>> be cached in some (webapp) classloader to help to exit faster? > >> > >> We need to test with various JDKs but if the results are comparable to > >> those for Java 11, I'd have no objection to simplifying the code. > > > > I've just run the performance test with Java 7, Java 8 and Java 11 with > > 8.5.x and in all three cases, the average time to run the test was less > > without the performance fix than with it. > > > > Given these, results, I think we remove this performance hack for all > > current versions. > > > > Objections? > > I would run under Java 17 just to make sure that whatever optimizations > were done in Java 11 are still there. I suspect there will be no change > in behavior, but as we have seen over the last 20 years, sometimes > things do change wrt performance. > > -chris > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
