> 2022年8月19日 00:18，Christopher Schultz <ch...@christopherschultz.net> 写道： > > Han, > > On 8/17/22 22:35, Han Li wrote: >> I found that BUILDING.txt in the source distribution of all version hasn’t >> been merged as expected. >> I think this is a source distribution, BUILDING.txt is part of the source, >> so it’s normal for this file not to be processed. > > Well, I know that if I had downloaded the source and intended to build it, I > would be surprised to find that the documentation says "Get yourself a copy > of Java @REQUIRED_JAVA_VERSION@" because I wouldn't know where to look. Indeed, I would be confused by this too, if I were a new user of Tomcat.
If we follow what you say, it does help new users who want to build Tomcat by themselves. Han > > If it comes out of git looking like that, it's fine. But the official source > distribution should really have easy-to-read documentation. > > -chris > >>> 2022年8月18日 09:36，Christopher Schultz <ch...@christopherschultz.net> 写道： >>> >>> All, >>> >>> On 8/17/22 21:23, Christopher Schultz wrote: >>>> I just noticed that BUILDING.txt in the source distribution of Tomcat >>>> 8.5.82 hasn't been merged as expected: >>>> " >>>> ==================================================== >>>> Building The Apache Tomcat @VERSION_MAJOR_MINOR@ Servlet/JSP Container >>>> ==================================================== >>>> This project contains the source code for Tomcat @VERSION_MAJOR_MINOR@, a >>>> container that >>>> implements the Servlet @SERVLET_SPEC_VERSION@, JSP @JSP_SPEC_VERSION@, EL >>>> @EL_SPEC_VERSION@, WebSocket @WEBSOCKET_SPEC_VERSION@ and JASPIC >>>> @JASPIC_SPEC_VERSION@ >>>> specifications from the Java Community Process <https://www.jcp.org/>. >>>> " >>>> I think we might need to enable token-replacement during copy. Or >>>> something else. I'll have a look. >>>> I'd also like to add some information about the repeatable build process. >>> >>> FWIW, the copy of BUILDING.txt that goes into >>> output/build/webapps/docs/BUILDING.txt is properly-merged. I think when >>> performing a "release" build, that file, once merged, need to be copied >>> over the BUILDING.txt that is at the root of the source archive. >>> >>> -chris >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> <mailto:dev-unsubscr...@tomcat.apache.org> >>> <mailto:dev-unsubscr...@tomcat.apache.org >>> <mailto:dev-unsubscr...@tomcat.apache.org>> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> <mailto:dev-h...@tomcat.apache.org> <mailto:dev-h...@tomcat.apache.org >>> <mailto:dev-h...@tomcat.apache.org>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > <mailto:dev-unsubscr...@tomcat.apache.org> > For additional commands, e-mail: dev-h...@tomcat.apache.org > <mailto:dev-h...@tomcat.apache.org>
