https://bz.apache.org/bugzilla/show_bug.cgi?id=66194
Bug ID: 66194
Summary: When using http2 and maxHeaderSize is exceeded,
nothing is logged
Product: Tomcat 9
Version: 9.0.63
Hardware: PC
OS: Mac OS X 10.1
Status: NEW
Severity: normal
Priority: P2
Component: Connectors
Assignee: dev@tomcat.apache.org
Reporter: damien.hol...@unimarket.com
Target Milestone: -----
We are using http2 and we have some requests with many cookies and this results
in us exceeding the maxHeaderSize limit. This has taken a very long time to
track down as tomcat does not log anything under these conditions - prior to
http2 I'm pretty sure this situation was logged (at least once).
The code in question is:
if (hpackDecoder.isHeaderSizeExceeded(headerReadBuffer.position())) {
StreamException headerException = new
StreamException(sm.getString(
"http2Parser.headerLimitSize", connectionId,
Integer.valueOf(streamId)),
Http2Error.ENHANCE_YOUR_CALM, streamId);
hpackDecoder.getHeaderEmitter().setHeaderException(headerException);
}
Note: it is logged if I turn on debug logging but we can't do that in
production.
o.a.coyote.http2.Http2UpgradeHandler : Connection [1], Stream [1], Error
[ENHANCE_YOUR_CALM], Message [Connection [1], Stream [1], Total header size too
big], RST (closing stream)
Could this be logged as a warning, so we can at least detect this situation in
production?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
