On 21/07/2022 07:06, Nemo wrote:

<snip/>

What happens if a vote doesn't pass or get vetoed - do the tags get deleted?

Release votes cannot be vetoed.

If a release vote doesn't pass, that release doesn't happen. In Tomcat, we'll fix whatever the problem was and then do another release. Version numbers are cheap so we just use the next one.

Once any artefacts have been made public using that tag - including for a release vote we never delete the tag as it is part of the record of what was voted on.

If we spot an issue with a tag before anything is uploaded, we will delete the tag, fix the issue and re-tag.

Perhaps the tagging/voting process should include a rc tag instead of a
release tag, so as to avoid getting released downstream accidentally?

I don't see that happening.

We have to vote on exactly what is being released. So even if we vote on an a.b.c-RC1 its version number has to be a.b.c. That creates an issue if we have multiple RCs. When a user reports an issue with version a.b.c we can't tell if that is a.b.c-RC1, a.b.c-RC2, a.b.c-RC3 etc.

There are ways to address this with the version number (e.g. add a build number) but we have been doing it this way for quite a while and it works for us.

Generally, I'd strongly discourage anyone from assuming that GitHub tag == ASF release.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to