markt-asf commented on PR #517:
URL: https://github.com/apache/tomcat/pull/517#issuecomment-1149625705

   I think the structure does match.
   
   The relevant text from RFC 2898 is:
   ```
   AlgorithmIdentifier { ALGORITHM-IDENTIFIER:InfoObjectSet } ::=
     SEQUENCE {
       algorithm ALGORITHM-IDENTIFIER.&id({InfoObjectSet}),
       parameters ALGORITHM-IDENTIFIER.&Type({InfoObjectSet}
       {@algorithm}) OPTIONAL
   }
   
   PBKDF2-params ::= SEQUENCE {
       salt CHOICE {
           specified OCTET STRING,
           otherSource AlgorithmIdentifier {{PBKDF2-SaltSources}}
       },
       iterationCount INTEGER (1..MAX),
       keyLength INTEGER (1..MAX) OPTIONAL,
       prf AlgorithmIdentifier {{PBKDF2-PRFs}} DEFAULT algid-hmacWithSHA1 }
   ```
   The relevant part of the key is:
   ```
      21:d=4  hl=2 l=   9 prim:     OBJECT            :PBKDF2
      32:d=4  hl=2 l=  28 cons:     SEQUENCE          
      34:d=5  hl=2 l=   8 prim:      OCTET STRING      [HEX 
DUMP]:BA170583ABCDBAF0
      44:d=5  hl=2 l=   2 prim:      INTEGER           :0800
      48:d=5  hl=2 l=  12 cons:      SEQUENCE          
      50:d=6  hl=2 l=   8 prim:       OBJECT            :hmacWithSHA256
      60:d=6  hl=2 l=   0 prim:       NULL    
   ```
   
   Taking each line from the key in turn:
   - Starts at PBKDF2 object
   - First we have a SEQUENCE
   - Next is the salt is an OCTET STRING
   - This is followed by the iterationCount
   - The keyLength isn't present but that is optional
   - The prf takes the form of AlgorithmIdentifier which is a SEQUENCE
   - There is one algorithm with NULL parameters and no optional field
   
   All that looks to be a match to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to