On Fri, May 20, 2022 at 9:35 AM Martin Grigorov <mgrigo...@apache.org> wrote: > > On Tue, May 17, 2022 at 4:23 PM Rémy Maucherat <r...@apache.org> wrote: > > > On Tue, May 17, 2022 at 12:27 PM Mark Thomas <ma...@apache.org> wrote: > > > > > > On 16/05/2022 14:14, Martin Grigorov wrote: > > > > Hello Tomcat devs, > > > > > > > > Some tests fail with JDK 19-ea+22-1598: > > > > > > <snip/> > > > > > > > [concat] Testsuites with failed tests: > > > > [concat] TEST-jakarta.el.TestImportHandlerStandardPackages.NIO.txt > > > > [concat] TEST-jakarta.el.TestImportHandlerStandardPackages.NIO2.txt > > > > > > <snip/> > > > > > > > Here are the error types: > > > > > > > > > > > > 1. Testsuite: jakarta.el.TestImportHandlerStandardPackages > > > > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.463 > > sec > > > > > > > > Testcase: testClassListsAreComplete took 0.444 sec > > > > FAILED > > > > java.lang.Thread.Builder.OfPlatform > > > > junit.framework.AssertionFailedError: > > java.lang.Thread.Builder.OfPlatform > > > > at > > > > > > jakarta.el.TestImportHandlerStandardPackages.lambda$checkPackageClassList$12(TestImportHandlerStandardPackages.java:77) > > > > at > > > > > > java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) > > > > at > > > > > > java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) > > > > at > > > > > > java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) > > > > > > I've fixed this one. Looking at the others. > > > > Ok, so since we're now adding support for Java 19 and the current > > trunk has the Panama preview API, I'll add a new "openssl-foreign" > > module that targets it. > > > > According to > https://github.com/openjdk/jdk/commit/2c5d136260fa717afa374db8b923b7c886d069b7 > the FF & Memory API is added in b23. > Above we were using b22. > > https://jdk.java.net/19/ has been just updated to b23. > > Do you want me to update JDK 19 at Buildbot (& Jenkins) to b23 ?
That's good news if you want to test the OpenSSL support with a more final version. I don't really know what kind of API changes can be expected following the preview, so we'll see how that goes. The API itself is a lot cleaner than the one from Java 17. One feature remaining that could be interesting depending on how it's done is: https://bugs.openjdk.java.net/browse/JDK-8254693 Allowing to pass heap byte buffers (as long as this capability remains flexible enough, if there's a surprise like "you can never deallocate it" then it's not going to be useful ...) would be very significant for Tomcat allowing to get rid of ugly memory copies and direct BB allocations. The full foreign task list is: https://bugs.openjdk.java.net/Dashboard.jspa?selectPageId=18412 Rémy > > > > > > Rémy > > > > > Mark > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
