Rainer Jung wrote:
I think I added those after I was frustrated by a customer whose mod_jk logs had all non-windows line endings. Sorry, I didn't really test your change, but my experience questions this patch.
With you patch the line endings were \r,\r,\n
Do we need to set text mode on the file? Will this work for direct logs and piped logs?
Text mode is default unless you open the file with "ab+" The "b" standing for binary. Probably not. The logs will have \n line endings unless the log rotator itself mangles them. Anyhow, either we can have binary files (using read/write) instead stdio for logs, and use platform specific lineends, or depend on the stdio provided ones. Regards, Mladen. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
