zisding opened a new pull request, #514: URL: https://github.com/apache/tomcat/pull/514
Hello, While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I found that the logging statements might give inaccurate messages. I also found that the in the line [465](https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/tomcat/util/modeler/Registry.java#L465) of the file Registry.java, the log messages says "Creating MBeanServer". However, the MBean server creation should already completed in previous code (line 463). Would it be better if we change the verb "Creating" to "Created" to indicate the action is completed? Or can we move the logging statement to the line before 463? Since when there was an exception in line 465, the logging message would not be printed, which may be not good for debugging. The detailed url is: https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/tomcat/util/modeler/Registry.java#L465 There is another same issue: in the line [378](https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/coyote/AbstractProtocol.java#L378) of the file AbstractProtocol.java, the log messages says "Added processor ...". However, the exact adding action (source code) is placed after the logging statement, which means that the add is still not completed. Would it be better if we change the verb "added" to "adding" to indicate the action is in progress? Or can we move the logging statement to the end of the method? The url of file: https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/coyote/AbstractProtocol.java#L378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
