markt-asf commented on PR #511: URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122094182
+1 to broadening the support of our PEM file conversion. I think the algorithm and the digest should be saved with the part for consistency with the rest of the code. I'm happy to do the refactoring to do that. Refactoring made me think about tests to make sure i didn't break anything. I noticed we don't have any tests for `PEMFile` so I'm going to add some at the same time. I should have something to commit shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
