ChristopherSchultz commented on PR #506: URL: https://github.com/apache/tomcat/pull/506#issuecomment-1119878843
> Writing an HTTP proxy is non-trivial. I am going to need a LOT of convincing that the proxy Valve is both safe and compliant with the relevant RFCs. I'd like to point out that, despite it's name, this is *not* a proxy. It's just fetching its error response from another server, so IMHO doesn't have any expectation of being compliant with any particular RFC(s). That said, I'm curious as to why any of this is necessary. You can set up whatever you want in `<error-page>` elements in `WEB-INF/web.xml` and handle errors any way you want including redirects, forwards, external-fetches, etc. There is no particular reason to create any new `Valve`s for these purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
