markt-asf commented on pull request #476: URL: https://github.com/apache/tomcat/pull/476#issuecomment-1046069257
I do think you should try and find the root cause of the issue you are observing as it might be causing other issues. I'm not convinced the proposed change is the right one. There should be no need to call `getMethod()` at all. If one of `owner`, `name` or `types` is `null` and `m` is `null`, calling `getMethod()` is just going to trigger an error. And `m` should not be `null` in that case anyway. Looking at the history, it appears two separate fixes were applied for the same issue: - https://bz.apache.org/bugzilla/show_bug.cgi?id=41797 - https://bz.apache.org/bugzilla/show_bug.cgi?id=44428 I'm going to refactor this and implement a different fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
