Am 13.01.2022 um 18:27 schrieb ma...@apache.org:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 2b6e19e971a980e38bcd30f05c554d9b798666c0
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Jan 13 16:36:32 2022 +0000
SWitch to building with Java 11 and using --release
Remove unnecessary references to compile.source and compile.target
Since we are now using release, that overrides source and target.
---
BUILDING.txt | 2 +-
build.xml | 82 +++++++++++++++---------------------------------------------
2 files changed, 21 insertions(+), 63 deletions(-)
diff --git a/build.xml b/build.xml
index 9597d3b..744eaab 100644
--- a/build.xml
+++ b/build.xml
...
@@ -211,33 +209,6 @@
<defaultexcludes remove="**/.gitignore" />
<!--<defaultexcludes echo="true" />-->
- <!-- Java 9 -->
- <available classname="java.lang.reflect.InaccessibleObjectException"
- property="java9.javadoc.options"
- value="-html5"/>
- <property name="java9.javadoc.options" value=""/>
-
- <available classname="java.lang.reflect.InaccessibleObjectException"
- property="java9.test.option.1"
- value="--add-opens=java.base/java.lang=ALL-UNNAMED"/>
- <property name="java9.test.option.1" value="-Dtest.1=1"/>
...
@@ -1969,13 +1929,11 @@
<jvmarg value="-Djava.library.path=${test.apr.loc}"/>
<jvmarg value="${test.formatter}"/>
<jvmarg
value="-Djava.net.preferIPv4Stack=${java.net.preferIPv4Stack}"/>
-
- <!-- Java 9 -->
- <jvmarg value="${java9.test.option.1}"/>
- <jvmarg value="${java9.test.option.2}"/>
- <jvmarg value="${java9.test.option.3}"/>
- <jvmarg value="${java9.test.option.4}"/>
- <jvmarg value="${java9.test.option.5}"/>
+ <jvmarg value="--add-opens=java.base/java.lang=ALL-UNNAMED"/>
+ <jvmarg value="--add-opens=java.base/java.io=ALL-UNNAMED"/>
+ <jvmarg value="--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED"/>
+ <jvmarg value="--add-opens=java.base/java.util=ALL-UNNAMED"/>
+ <jvmarg
value="--add-opens=java.base/java.util.concurrent=ALL-UNNAMED"/>
Is there still a way of running the unit tests with older JVMs, like
Java 8? I understand, that e switched the build process to Java 11+, but
wouldn't it be nice to have the opportunity to check the unit tests with
the minimum target release?
Altough it makes build.xml slightly more complex, it would probably
suffice to revert the change of making the Java 9+ jvmargs non-optional.
WDYT?
Best regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
