Mikhail2048 commented on pull request #461: URL: https://github.com/apache/tomcat/pull/461#issuecomment-987771204
> > Becuase this code, for example : `new Base64().decode(myString)` will produce NPE in case of myString is `null`. This is becuase of inner delegation to `public byte[] decode(final byte[] pArray)` method (in `BaseNCodec` class), which cannot handle null values. > > It make sense to `encode` a empty string, but it does not make sense to `encode` or `decode` a `null` string. I agree with that, but it forces the client the be aware of the fact that string is not null. I am responsible to check it, as a Client - why? I genuinely do not understand the logic behind it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
