Of course. I want it the other way round. Adding the pid to the file name would prevent users from erroneously sharing the shm file via it's default value.

Consider users who have an apache httpd installed as a product and 2 separate instances (conf, logs, run etc.) defined. Since httpd does not really have a nice way to distinguish between the product and the instance (like catalina_home and catalina_base), you have to decide if you set your ServerRoot to the product directory (and then use full path names for the files in the instance) or the other way round.

If a user has ServerRoot set to the product directory and explicitely sets the conf and logs files to the instance directory, but does not set an explicit JkShmFile, all instances will share the same JkShmFile in the ServerRoot logs, which will obviously produce *very* bad results.

Even more: if they put their JkShmFile into a shared run directory (like /var/apache/run) and don't communicate about not using the same name, the same problem will happen. For this reason most of the usual httpd lock/pid/status etc. files already include the parent process pid in their file name, so that no clash will happen. Some of the files, which did not include the pid for httpd 2.0, do for 2.2.

I have the impression, that this would be nice for our shm file too.

Regards,

Rainer

Mladen Turk wrote:
Rainer Jung wrote:
Hi Mladen,

I didn't really read this commit, but it's Log entry reminds me of the following:


This is for shm lock, not for the shared memory, so the name is
irrelevant, and will be destroyed on exit.

Also, we store workers in shared memory, so any attempt to
have a shared memory between instances is tricky, because
it can lead to a total mess if the configuration is not
exactly the same (even ordering matters).

Regards,
Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to