This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push: new 22d06ed Add a note 22d06ed is described below commit 22d06ed6c72cd8964b6f5314535cf31cbcdadd4f Author: remm <r...@apache.org> AuthorDate: Mon Nov 8 23:48:09 2021 +0100 Add a note After comparing the code with the panama-foreign API, which allows writing to an address. --- .../java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java b/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java index 374c808..f976432 100644 --- a/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java +++ b/modules/openssl-java17/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java @@ -826,6 +826,8 @@ public class OpenSSLContext implements org.apache.tomcat.util.net.SSLContext { // const unsigned char *in, unsigned int inlen, void *arg) public int openSSLCallbackAlpnSelectProto(MemoryAddress ssl, MemoryAddress out, MemoryAddress outlen, MemoryAddress in, int inlen, MemoryAddress arg) { + // It would be better to read byte by byte as the ALPN data is very small + // However, the Java 17 API forces use of a scope later on, so create one for everything try (ResourceScope scope = ResourceScope.newConfinedScope()) { byte[] advertisedBytes = in.asSegment(inlen, scope).toByteArray(); ArrayList<byte[]> negotiableProtocolsBytes = new ArrayList<>(negotiableProtocols.size() + 1); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org