On Wed, Oct 20, 2021 at 3:39 PM Mark Thomas <[email protected]> wrote:
> I'm not seeing those failures with OpenJDK 17.0.1 > I see the test is added 8 days ago, so most probably it is not related to the JDK version at all. > > The response line and body look to be correct to me. > > The failure appears to be with the request body. Is it possible you > aren't using UTF-8 for the *.java file? You could try using > I just clone the Git repo. It should use the encoding of the file. > "/foo\u20acbar" as the expected canonicalized URI. > I will test it now! First, I will replace assertTrue with assertEquals at https://github.com/apache/tomcat/commit/fee1f457f287a56d3d490a5ab5b3f643d280ecf5#diff-fae30dfd485f718b7b7d76763204c70a1d7257d319018763b98366d3f446decbR200 > > Mark > > > On 20/10/2021 12:53, Martin Grigorov wrote: > > Hi, > > > > Today I've tested JDK 17.0.1 and noticed these failures: > > > > Testcase: testCanonicalizationSpecification[49: > > requestURI[/foo%E2%82%ACbar]] took 0.055 sec > > FAILED > > HTTP/1.1 200 > > /foo€bar > > junit.framework.AssertionFailedError: HTTP/1.1 200 > > /foo€bar > > at > > > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200) > > at > > > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationSpecification(TestCoyoteAdapterCanonicalization.java:156) > > at jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown > > Source) > > at > > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > > > Testcase: testCanonicalizationTomcat[49: requestURI[/foo%E2%82%ACbar]] > took > > 0.087 sec > > FAILED > > HTTP/1.1 200 > > /foo€bar > > junit.framework.AssertionFailedError: HTTP/1.1 200 > > /foo€bar > > at > > > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200) > > at > > > org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationTomcat(TestCoyoteAdapterCanonicalization.java:161) > > at jdk.internal.reflect.GeneratedMethodAccessor29.invoke(Unknown > > Source) > > at > > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > > > > They fail consitently on both x86_64 and aarch64. > > > > Regards, > > Martin > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
