On 11/10/2021 22:41, Christopher Schultz wrote:
On 10/11/21 10:04, ma...@apache.org wrote:
<snip/>
+ @Deprecated
+ public static final String LEGACY_DO_HEAD =
"jakarta.servlet.http.legacyDoHead";
Since 6.0? Looks like you are adding it to 10.x.
You are correct. It is "Servlet 6.0".
Also, is it appropriate to use the "jakarta.*" namespace, here?
It is specification defined, so yes.
<snip/>
Hmm, okay. Should we say "@since Servlet 6.0" since it's not clear what
the version means? Or, because it's in HttpServlet (which is defined by
servlet.spec), is it implied that all versions will mean "(of the
servlet spec)"?
I think adding the explicit "Servlet" is a good idea. I'll check all of
the @since tags in the spec classes and make sure they name the spec.
For the main Tomcat code, I think it is OK to not include "Tomcat" or
"Apache Tomcat".
Looking at the main code, we haven't used @since very consistently (or
at all really) for 8.5.x onwards. I'm wondering if we should just remove
all the @since tags that refer to Tomcat 8.0.x and earlier.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
