вт, 7 сент. 2021 г. в 10:54, Mark Thomas <ma...@apache.org>:
>
> On 07/09/2021 08:20, Rémy Maucherat wrote:
> > On Tue, Sep 7, 2021 at 8:42 AM Konstantin Kolinko
> > <knst.koli...@gmail.com> wrote:
> >>
> >> пн, 6 сент. 2021 г. в 21:28, <ma...@apache.org>:
> >>>
> >>> Author: markt
> >>> Date: Mon Sep 6 18:28:21 2021
> >>> New Revision: 49785
> >>>
> >>> Log:
> >>> Upload 10.0.11 for voting
> >>>
> >>> Added:
>
> <snip/>
>
> >>> dev/tomcat/tomcat-10/v10.0.11/bin/apache-tomcat-10.0.11.tar.gz
> >>> (with props)
> >>> dev/tomcat/tomcat-10/v10.0.11/bin/apache-tomcat-10.0.11.tar.gz.sha512
> >>> dev/tomcat/tomcat-10/v10.0.11/bin/apache-tomcat-10.0.11.zip (with
> >>> props)
> >>> dev/tomcat/tomcat-10/v10.0.11/bin/apache-tomcat-10.0.11.zip.sha512
> >>
> >> *.asc files are missing for apache-tomcat-10.0.11.tar.gz and
> >> apache-tomcat-10.0.11.zip above.
> >
> > This is a funny one. The build.xml is fine, there's no error building,
> > but the signature for these two files didn't happen. There's a bug
> > somewhere ...
>
> Indeed. I can't see what it is though. The Ant build is, as far as I am
> aware, single threaded so everything should be sequential.
I think "res/maven/mvn-pub.xml" deletes those files.
There is
[[[
<target name="maven-deploy-binaries" depends="init-maven">
<!--cleanup-->
<delete file="${pom}.tmp"/>
<delete file="${pom}.asc"/>
<delete file="${file}.zip.asc"/>
<delete file="${file}.tar.gz.asc"/>
...
]]]
And it is called with
file="${tomcat.release.path}/v${maven.deploy.binary.version}/bin/apache-tomcat-${maven.deploy.binary.version}"/>
and operates on the files that are in the "release" directory.
If mvn-pub.xml is called before "svn add && svn commit" (that uploads
the files to dist.a.o) completes, you may see a race.
A possible solution
- Modify mvn-pub.xml so that it uses GPG to validate existing asc
signatures for .zip and .tar.gz files, instead of deleting and
recreating them.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
