Le jeu. 8 juil. 2021 à 15:36, Rémy Maucherat <r...@apache.org> a écrit :
> On Thu, Jul 8, 2021 at 1:21 PM Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: > > > > Hi Mark, > > > > My understanding of the issue is that the isGraal test is not sufficient > > and should be precised to be isGraalNative (just using the naming to > > express the idea). > > Graal is a plain JVM and this does not need any hack but when > native-image > > is used it needs all current hacks so guess the test is not precise > enough > > but that the disabling should stay by default for native-image. > > This is more complex since the "Graal native" mode must also be > enabled when using the agent, and that's basically what the flag does. > If running Graal without the agent, then the isGraal flag returns > false. The "org.graalvm.nativeimage.imagecode" system property > override might get in the way however since the Spring code hacks it. > The check could be refined there maybe. > Well it is only true when tomcats itself uses the agent to generate the json config files so guess the CLI arg or any other config works as well there. (for end users you still have to tune a tons of things after so not sure it is that used and should be considered for that issue) > > Rémy > > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > Le jeu. 8 juil. 2021 à 13:01, Mark Thomas <ma...@apache.org> a écrit : > > > > > Hi, > > > > > > I got pinged on this issue yesterday: > > > > > > > https://github.com/spring-projects-experimental/spring-native/issues/805#issuecomment-875335648 > > > > > > That reads to me as if Graal now supports the use of JMX. If that is > the > > > case I think we can remove this code: > > > > > > > > > > https://github.com/apache/tomcat/blob/main/java/org/apache/tomcat/util/modeler/Registry.java#L139 > > > > > > and go back to the standard --no-jmx or calling > > > Registry.disableRegistry() for those users that don't want JMX support. > > > > > > Thoughts? > > > > > > I plan to make this change early next week if there are no objections. > > > > > > Mark > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
