cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-865024538
> The only thing that I'm really wondering about is why the UserDatabaseRealm did not get arbitrary attributes. My first focus was on UserDatabaseRealm and JDNIRealm. Arbitrary user attributes for UserDatabaseRealm sounds interesting. However, I did not yet think about it in detail. AFAIK, there is a schema file for tomcat-users.xml. Some new Digester rules must be defined. Actually, the attributes come from the `User` instance. Likely this class should get an attributes map as well (which we then can provide through `UserDatabasePrincipal`). I'm almost finished with all the changes caused by that code review. Also, I've added support for SQL types ARRAY, BLOB, and CLOB. I will push my latest commits soon. Still open/pending: - Using *linked* hash maps (yes/no) - Defensive copies (how paranoid shall we go?) - Documentation (likely my job) The latter might be quite challenging. Needs additions in `config/realm.html` and likely in `realm-howto.html`. Since, at current, only `TomcatPrincipal` supports the attribute stuff, maybe a code example in one of the HTML sites will be required. Has anyone thought about putting these methods to a more _official_ interface `jakarta.servlet.Principal`? Since it is now _jakarta_, is Apache or Tomcat now responsible for the Servlet Standard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
