This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push: new 0251dd8 Act on rather old TODO comment 0251dd8 is described below commit 0251dd89725d5e0d96503c561b4b3e1f9dfc68b8 Author: Mark Thomas <ma...@apache.org> AuthorDate: Tue Jun 15 20:54:46 2021 +0100 Act on rather old TODO comment --- java/org/apache/catalina/valves/RemoteIpValve.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/org/apache/catalina/valves/RemoteIpValve.java b/java/org/apache/catalina/valves/RemoteIpValve.java index cdfa77e..e2cd6d3 100644 --- a/java/org/apache/catalina/valves/RemoteIpValve.java +++ b/java/org/apache/catalina/valves/RemoteIpValve.java @@ -19,6 +19,7 @@ package org.apache.catalina.valves; import java.io.IOException; import java.net.InetAddress; import java.net.UnknownHostException; +import java.util.Deque; import java.util.Enumeration; import java.util.LinkedList; import java.util.regex.Pattern; @@ -597,8 +598,7 @@ public class RemoteIpValve extends ValveBase { if (isInternal || (trustedProxies != null && trustedProxies.matcher(originalRemoteAddr).matches())) { String remoteIp = null; - // In java 6, proxiesHeaderValue should be declared as a java.util.Deque - LinkedList<String> proxiesHeaderValue = new LinkedList<>(); + Deque<String> proxiesHeaderValue = new LinkedList<>(); StringBuilder concatRemoteIpHeaderValue = new StringBuilder(); for (Enumeration<String> e = request.getHeaders(remoteIpHeader); e.hasMoreElements();) { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org