https://bz.apache.org/bugzilla/show_bug.cgi?id=65333
Bug ID: 65333 Summary: 8.5.64 and 8.5.66 introduced undocumented backward compatibility breaking changes in HostConfig methods available through JMX Product: Tomcat 8 Version: 8.5.66 Hardware: All OS: All Status: NEW Severity: regression Priority: P2 Component: Manager Assignee: dev@tomcat.apache.org Reporter: ismae...@gmail.com Target Milestone: ---- The following commits introduce undocumented backward compatibility breaking changes in HostConfig: - https://github.com/apache/tomcat/commit/b923a7bb288c428d49f7323fedbf5ac79bdf6700#diff-28c2be466490f0a2d3b42c81c95168050789a60f4719027adb47b2ff99f636ed - https://github.com/apache/tomcat/commit/64387fa67375330a8dc44148f687349f783e4e7d#diff-28c2be466490f0a2d3b42c81c95168050789a60f4719027adb47b2ff99f636ed - https://github.com/apache/tomcat/commit/85731b9a923125b228f91ef3eb69539e57a54457#diff-28c2be466490f0a2d3b42c81c95168050789a60f4719027adb47b2ff99f636ed - https://github.com/apache/tomcat/commit/978134282acd5da1bbdeb9eb09fff2e0c6479a68#diff-28c2be466490f0a2d3b42c81c95168050789a60f4719027adb47b2ff99f636ed - https://github.com/apache/tomcat/commit/996bd6194952114ec5b0da3010b117c6797d0d2b#diff-28c2be466490f0a2d3b42c81c95168050789a60f4719027adb47b2ff99f636ed More specifically, calling "addServiced" before "check" now has collateral effects that cause unexpected effects. Now, the "check" method implicitly calls "tryAddServiced", and if the method returns "false", it doesn't call "checkResources". So, calling "addServiced" before "check" will cause "check" to not execute "checkResources". If pre-8.5.64 behavior is no longer acceptable for this API, maybe these changes should be documented in http://tomcat.apache.org/migration-85.html#Upgrading_8.5.x. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org