This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 6387015 Language improvements
6387015 is described below
commit 6387015bdca4ae3d2ca42d7852977a1e94e1a1f2
Author: Mark Thomas <[email protected]>
AuthorDate: Sun May 23 19:43:15 2021 +0100
Language improvements
Identified by https://clcdemo.net/analysis.html?project=tomcat.git
---
java/javax/servlet/ServletContext.java | 5 +++--
java/org/apache/catalina/DistributedManager.java | 2 +-
java/org/apache/catalina/Globals.java | 4 ++--
java/org/apache/catalina/servlets/DefaultServlet.java | 2 +-
java/org/apache/catalina/startup/Constants.java | 3 ++-
java/org/apache/catalina/util/ExtensionValidator.java | 4 ++--
.../catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java | 2 +-
webapps/docs/appdev/web.xml.txt | 2 +-
8 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/java/javax/servlet/ServletContext.java
b/java/javax/servlet/ServletContext.java
index 91b4f34..03147c1 100644
--- a/java/javax/servlet/ServletContext.java
+++ b/java/javax/servlet/ServletContext.java
@@ -429,8 +429,9 @@ public interface ServletContext {
* parameter does not exist.
* <p>
* This method can make available configuration information useful to an
- * entire "web application". For example, it can provide a webmaster's
email
- * address or the name of a system that holds critical data.
+ * entire "web application". For example, it can provide a web site
+ * administrator's email address or the name of a system that holds
critical
+ * data.
*
* @param name
* a <code>String</code> containing the name of the parameter
diff --git a/java/org/apache/catalina/DistributedManager.java
b/java/org/apache/catalina/DistributedManager.java
index 561c488..612ebbe 100644
--- a/java/org/apache/catalina/DistributedManager.java
+++ b/java/org/apache/catalina/DistributedManager.java
@@ -25,7 +25,7 @@ import java.util.Set;
* BackupManager is an example of such a Manager as are implementations of the
* StoreManager interface.
* <p>
- * With the BackupManager, sessions can be primary (master copy on this node),
+ * With the BackupManager, sessions can be primary (primary copy on this node),
* backup (backup copy on this node) or proxy (only the session ID on this
* node). The identity of the primary and backup nodes are known for all
* sessions, including proxy sessions.
diff --git a/java/org/apache/catalina/Globals.java
b/java/org/apache/catalina/Globals.java
index f1d2815..0721331 100644
--- a/java/org/apache/catalina/Globals.java
+++ b/java/org/apache/catalina/Globals.java
@@ -286,8 +286,8 @@ public final class Globals {
// -------------------------------------------------------- Global
constants
/**
- * The master flag which controls strict servlet specification
- * compliance.
+ * The flag which controls strict servlet specification compliance. Setting
+ * this flag to {@code true} will change the defaults for other settings.
*/
public static final boolean STRICT_SERVLET_COMPLIANCE =
Boolean.parseBoolean(System.getProperty("org.apache.catalina.STRICT_SERVLET_COMPLIANCE",
"false"));
diff --git a/java/org/apache/catalina/servlets/DefaultServlet.java
b/java/org/apache/catalina/servlets/DefaultServlet.java
index 062b979..50241a7 100644
--- a/java/org/apache/catalina/servlets/DefaultServlet.java
+++ b/java/org/apache/catalina/servlets/DefaultServlet.java
@@ -371,7 +371,7 @@ public class DefaultServlet extends HttpServlet {
useAcceptRanges =
Boolean.parseBoolean(getServletConfig().getInitParameter("useAcceptRanges"));
}
- // Sanity check on the specified buffer sizes
+ // Prevent the use of buffer sizes that are too small
if (input < 256) {
input = 256;
}
diff --git a/java/org/apache/catalina/startup/Constants.java
b/java/org/apache/catalina/startup/Constants.java
index fa0bc98..fbe2d0f 100644
--- a/java/org/apache/catalina/startup/Constants.java
+++ b/java/org/apache/catalina/startup/Constants.java
@@ -37,7 +37,8 @@ public final class Constants {
public static final String WarTracker = "/META-INF/war-tracker";
/**
- * A dummy value used to suppress loading the default web.xml file.
+ * A value that points to a non-existent file used to suppress loading the
+ * default web.xml file.
*
* <p>
* It is useful when embedding Tomcat, when the default configuration is
diff --git a/java/org/apache/catalina/util/ExtensionValidator.java
b/java/org/apache/catalina/util/ExtensionValidator.java
index e308a5e..ec6720a 100644
--- a/java/org/apache/catalina/util/ExtensionValidator.java
+++ b/java/org/apache/catalina/util/ExtensionValidator.java
@@ -36,8 +36,8 @@ import org.apache.tomcat.util.res.StringManager;
/**
* Ensures that all extension dependencies are resolved for a WEB application
- * are met. This class builds a master list of extensions available to an
- * application and then validates those extensions.
+ * are met. This class builds a list of extensions available to an application
+ * and then validates those extensions.
*
* See http://docs.oracle.com/javase/1.4.2/docs/guide/extensions/spec.html
* for a detailed explanation of the extension mechanism in Java.
diff --git
a/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
b/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
index 4661a24..2df5ad5 100644
---
a/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
+++
b/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
@@ -121,7 +121,7 @@ public class TestSSOnonLoginAndBasicAuthenticator extends
TomcatBaseTest {
private String encodedURL;
/*
- * Run some sanity checks without an established SSO session
+ * Run some checks without an established SSO session
* to make sure the test environment is correct.
*/
@Test
diff --git a/webapps/docs/appdev/web.xml.txt b/webapps/docs/appdev/web.xml.txt
index b560a73..8f07916 100644
--- a/webapps/docs/appdev/web.xml.txt
+++ b/webapps/docs/appdev/web.xml.txt
@@ -53,7 +53,7 @@
-->
<context-param>
- <param-name>webmaster</param-name>
+ <param-name>webadmin</param-name>
<param-value>[email protected]</param-value>
<description>
The EMAIL address of the administrator to whom questions
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
