jeanouii commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630372233
##########
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##########
@@ -335,8 +344,15 @@ public void init() throws ServletException {
}
}
- if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
- useBomIfPresent =
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+ final String useBomIfPresentConfig =
getServletConfig().getInitParameter("useBomIfPresent");
+ if (useBomIfPresentConfig != null) {
+ if (!Arrays.asList("true", "false",
"pass-through").contains(useBomIfPresentConfig)) {
Review comment:
I made it such as it's fully backward compatible from a suer perspective
and according to the discussions on the list. So we should be good in that
regard.
@martin-g All good to me. All feedback always welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
