Jean-Louis,

On 5/5/21 09:49, Jean-Louis MONTEIRO wrote:
Now that we crossed the finish line with TomEE compatibility, I'd like to give back the BOM changes according to this discussion.

I did the updated and created another subclass for DefaultServletEncodingBaseTest
image.png
Did some fixes around that test to take the changes into account.
I'll see if I can get this to fully pass

image.png

Good news, it's backward compatible as we wanted.
I may post if I need some help or guidance.

As soon as it's done, I believe we want a bugzilla ticket so I can link it to a PR?

All the images were stripped from the list-posting.

Either Bugzilla or GitHub PR is fine.

-chris

Le jeu. 15 avr. 2021 à 19:19, Christopher Schultz <ch...@christopherschultz.net <mailto:ch...@christopherschultz.net>> a écrit :

    Mark,

    On 4/15/21 04:57, Mark Thomas wrote:
     > If we wanted to address this and provide a way to allow JSTL to
    have the
     > control over the included content required to pass this TCK test
    then we
     > could modify 'useBomIfPresent' as follows:
     >
     > - true   - no change - remains the default
     >
     > - false  - no change
     >
     > - ignore - as current false but does not strip the BoM from the
    output

    I might re-name the "ignore" case to "pass-through" to be perfectly
    clear about what's happening. "Ignore" might be mis-interpreted to mean
    that the BOM would be removed. "Pass-through" makes it clear that the
    BOM will still be sent IMHO.

    -chris

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
    <mailto:dev-unsubscr...@tomcat.apache.org>
    For additional commands, e-mail: dev-h...@tomcat.apache.org
    <mailto:dev-h...@tomcat.apache.org>



--
Jean-Louis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to