This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new 646b807  Remove unnecessary code
646b807 is described below

commit 646b807462b3074d0633cdf04f36965d79fcafc5
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Apr 19 14:27:53 2021 +0100

    Remove unnecessary code
---
 java/org/apache/jasper/compiler/Generator.java | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/jasper/compiler/Generator.java 
b/java/org/apache/jasper/compiler/Generator.java
index 638dac4..27a8326 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -1342,8 +1342,10 @@ class Generator {
                     // and (for Java 9+) in an exported module
                     int modifiers = bean.getModifiers();
                     JreCompat jreCompat = JreCompat.getInstance();
+                    // No need to test for being an interface here as the
+                    // getConstructor() call above will have already failed for
+                    // any interfaces.
                     if (!Modifier.isPublic(modifiers) ||
-                            Modifier.isInterface(modifiers) ||
                             Modifier.isAbstract(modifiers) ||
                             !jreCompat.canAccess(null, constructor) ) {
                         throw new 
Exception(Localizer.getMessage("jsp.error.invalid.bean",

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to