https://bz.apache.org/bugzilla/show_bug.cgi?id=65211
--- Comment #2 from Konstantin Kolinko <knst.koli...@gmail.com> --- Created attachment 37790 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37790&action=edit catalina_sh_TC9_0_7.diff The modified version of catalina.sh looks to be rather outdated - based on the one from Apache Tomcat 9.0.7 (released on 2018-04-07). I am attaching a diff against that version. - It has changes committed on 2018-03-21 ("Always send the OS's umask to the JVM"). - It does not have changes from 2018-04-27 ("Avoid warning when running under Cygwin when the JAVA_ENDORSED_DIRS environment variable is not set.") The changes against the original version are: 1) A rename, s/CATALINA_HOME/CATALINA_HOME_HPAPLS/g 2) A custom block of code that processes some environment variables and updates some custom copy of "catalina.properties" file. Note that instead of modifying the original startup scripts the recommended way to customize an installation of Apache Tomcat is to create a custom bin/setenv.sh script file. This is documented in RUNNING.txt. BTW, - I see that all updates to a custom catalina.properties file are appends ('>> ...'). I wonder how that file is reset between runs. - The path to the custom catalina.properties file is hard-coded, instead of using environment variable $CATALINA_BASE. - A hard-coded default value for SRV_KS_PWD. That is what I see from a technical point of view. I am not commenting on whether I see a licensing issue here. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
