rmaucher commented on pull request #414: URL: https://github.com/apache/tomcat/pull/414#issuecomment-801817917
This was introduced by https://github.com/apache/tomcat/commit/c38e9ccabc0d20e1f88b389ab531dcbf632b0ed8 and I understand the WebappLoader changes part of it. In StandardContext, I don't see why the properties should not be set simply after using if (getLoader().getClassLoader() instanceof WebappClassLoaderBase) since the StandardContext class already uses WebappLoader (to create a default loader). This would avoid the useless reflection that is causing you problems. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
