DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37072>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37072


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[EMAIL PROTECTED]
                   |                            |om




------- Additional Comments From [EMAIL PROTECTED]  2007-02-26 00:25 -------
How about the following corrections?

org.apache.catalina.connector.Response:
---
    public void reset(int status, String message) {
        reset();
        setStatus(status, message);
        usingWriter = false; // add for user error page
    }
---
This makes the user error page be able to set encoding again.
Even if there is already a generated Writer object,
I think it has not been referred any longer usually because 
the application(filter, servlet, etc.) is already over.


org.apache.catalina.valves.ErrorReportValve:
in  protected void report(Request request, Response response, Throwable 
throwable)
...
try {
    response.setContentType("text/html");
    response.setCharacterEncoding("utf-8");
    
    // add for default error page
    if(!"utf-8".equals(response.getCharacterEncoding())){
        response.getCoyoteResponse().setCharacterEncoding("utf-8");
    }
} catch (Throwable t) {
...
If the writer object is already generated, setCharacterEncoding will not work.
So I think we must force set encoding direct to coyote response.


I know the specification says setCharacterEncoding should effect only before 
getWriter,
and says nothing about getWriter in reset method description.
But we need a fix in multi byte character environment.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to