michael-o commented on a change in pull request #406:
URL: https://github.com/apache/tomcat/pull/406#discussion_r588501243
##########
File path: java/org/apache/catalina/valves/SSLValve.java
##########
@@ -137,7 +149,13 @@ public void invoke(Request request, Response response)
throws IOException, Servl
* separate lines, the CertificateFactory is tolerant of any
* additional whitespace.
*/
- String headerValue = mygetHeader(request, sslClientCertHeader);
+ String headerValue;
+ String headerEscapedValue = mygetHeader(request,
sslClientEscapedCertHeader);
+ if (headerEscapedValue != null) {
+ headerValue = URLDecoder.decode(headerEscapedValue, "ISO-8859-1");
Review comment:
Yes, I was referring to the UDecoder. I have nagged last year the usage
of URLEncoder and Mark removed it. We should avoid it altogether for
concistency. Since URLs are by default UTF-8, you should use UTF-8 unless there
is a good reason for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
