On 23/02/2021 13:04, Mark Thomas wrote: > On 23/02/2021 12:50, ma...@apache.org wrote: >> This is an automated email from the ASF dual-hosted git repository. >> >> markt pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/tomcat.git >> >> >> The following commit(s) were added to refs/heads/master by this push: >> new 5e974d6 Fix BZ 64938 Clarify expected behaviour of >> setCharacterEncoding(null) >> 5e974d6 is described below >> >> commit 5e974d66cd4edcb9f18207d90b2ecd433104ec06 >> Author: Mark Thomas <ma...@apache.org> >> AuthorDate: Tue Feb 23 12:49:59 2021 +0000 >> >> Fix BZ 64938 Clarify expected behaviour of setCharacterEncoding(null) >> >> Also covers setContentType(null) and setLocale(null) >> https://bz.apache.org/bugzilla/show_bug.cgi?id=64938 > > Thoughts on back-porting this? The functional changes should be: > > 1. Calling various methods with null undoes previous calls to that > method and related methods as per latest Jakarta Servlet Javadoc. > > 2. Using an invalid character set will trigger an > UnsupportedEncodingException rather than using the default encoding when > getWriter() is called. > > The null changes seem safe. Calling those methods with null was arguably > not allowed by the previous Javadoc so users should not have been doing > that. > > 2 might break something but it seems unlikely. Exposing what was > previously a silently swallowed error seems a good thing to me. > > Maybe the getWriter() behaviour needs to be configurable in 9.0.x and > earlier? Although I'd prefer not to add an option. > > I'll delay back-porting this for a few days to give us a chance to > discuss it.
There hasn't been any feedback so far so my current plan is to back-port this some time tomorrow. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
