On Mon, Feb 8, 2021 at 11:18 AM Martin Grigorov <mgrigo...@apache.org>
wrote:

> Hi Rémy,
>
> On Mon, Feb 8, 2021 at 11:23 AM Rémy Maucherat <r...@apache.org> wrote:
>
> > On Mon, Feb 8, 2021 at 10:10 AM Martin Grigorov <mgrigo...@apache.org>
> > wrote:
> >
> > > Hi devs,
> > >
> > > TestXxxEndpoint fails concitently on both JDK 16 b35 and JDK 17 b8
> with:
> > >
> > > Testsuite: org.apache.tomcat.util.net.TestXxxEndpoint
> > > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.983
> sec
> > > ------------- Standard Error -----------------
> > > 08-Feb-2021 08:38:08.129 INFO [main]
> > > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > > [testUnixDomainSocket]
> > > 08-Feb-2021 08:38:08.867 INFO [main]
> > > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-1"]
> > > 08-Feb-2021 08:38:08.926 INFO [main]
> > > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > > [testStartStopBindOnStart]
> > > 08-Feb-2021 08:38:11.842 INFO [main]
> > > org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2"]
> > > 08-Feb-2021 08:38:11.976 INFO [main]
> > > org.apache.catalina.core.StandardService.startInternal Starting service
> > > [Tomcat]
> > > 08-Feb-2021 08:38:11.979 INFO [main]
> > > org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
> > > engine: [Apache Tomcat/10.0.3-dev]
> > > 08-Feb-2021 08:38:12.813 INFO [main]
> > > org.apache.catalina.startup.ContextConfig.getDefaultWebXmlFragment No
> > > global web.xml found
> > > 08-Feb-2021 08:38:14.322 INFO [main]
> > > org.apache.jasper.servlet.TldScanner.scanJars At least one JAR was
> > scanned
> > > for TLDs yet contained no TLDs. Enable debug logging for this logger
> for
> > a
> > > complete list of JAR
> > > s that were scanned but no TLDs were found in them. Skipping unneeded
> > JARs
> > > during scanning can improve startup time and JSP compilation time.
> > > 08-Feb-2021 08:38:14.462 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log ContextListener:
> > > contextInitialized()
> > > 08-Feb-2021 08:38:14.463 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log SessionListener:
> > > contextInitialized()
> > > 08-Feb-2021 08:38:14.483 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log ContextListener:
> > > attributeAdded('StockTicker', 'async.Stockticker@3a12c404')
> > > 08-Feb-2021 08:38:14.667 INFO [main]
> > > org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2"]
> > > 08-Feb-2021 08:38:14.812 INFO [main]
> > > org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2-34601"]
> > > 08-Feb-2021 08:38:14.824 INFO [main]
> > > org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2"]
> > > 08-Feb-2021 08:38:14.966 INFO [main]
> > > org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2"]
> > > 08-Feb-2021 08:38:14.967 INFO [main]
> > > org.apache.catalina.core.StandardService.stopInternal Stopping service
> > > [Tomcat]
> > > 08-Feb-2021 08:38:14.971 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log SessionListener:
> > > contextDestroyed()
> > > 08-Feb-2021 08:38:14.972 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log ContextListener:
> > > contextDestroyed()
> > > 08-Feb-2021 08:38:15.024 INFO [main]
> > > org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2"]
> > > 08-Feb-2021 08:38:15.128 INFO [main]
> > > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-2"]
> > > 08-Feb-2021 08:38:15.134 INFO [main]
> > > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > > [testStartStopBindOnInit]
> > > 08-Feb-2021 08:38:15.135 INFO [main]
> > > org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3"]
> > > 08-Feb-2021 08:38:15.240 INFO [main]
> > > org.apache.catalina.core.StandardService.startInternal Starting service
> > > [Tomcat]
> > > 08-Feb-2021 08:38:15.240 INFO [main]
> > > org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
> > > engine: [Apache Tomcat/10.0.3-dev]
> > > 08-Feb-2021 08:38:15.252 INFO [main]
> > > org.apache.catalina.startup.ContextConfig.getDefaultWebXmlFragment No
> > > global web.xml found
> > > 08-Feb-2021 08:38:15.747 INFO [main]
> > > org.apache.jasper.servlet.TldScanner.scanJars At least one JAR was
> > scanned
> > > for TLDs yet contained no TLDs. Enable debug logging for this logger
> for
> > a
> > > complete list of JAR
> > > s that were scanned but no TLDs were found in them. Skipping unneeded
> > JARs
> > > during scanning can improve startup time and JSP compilation time.
> > > 08-Feb-2021 08:38:15.767 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log ContextListener:
> > > contextInitialized()
> > > 08-Feb-2021 08:38:15.768 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log SessionListener:
> > > contextInitialized()
> > > 08-Feb-2021 08:38:15.769 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log ContextListener:
> > > attributeAdded('StockTicker', 'async.Stockticker@2f48b3d2')
> > > 08-Feb-2021 08:38:15.774 INFO [main]
> > > org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3-39117"]
> > > 08-Feb-2021 08:38:15.817 INFO [main]
> > > org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3-39117"]
> > > 08-Feb-2021 08:38:15.838 INFO [main]
> > > org.apache.tomcat.util.net.TestXxxEndpoint.testStartStopBindOnInit
> > > Exception was
> > >         java.net.BindException: Address already in use
> > >                at java.base/sun.nio.ch.Net.bind0(Native Method)
> > >                 at java.base/sun.nio.ch.Net.bind(Net.java:552)
> > >                 at java.base/sun.nio.ch.Net.bind(Net.java:541)
> > >                 at
> > > java.base/sun.nio.ch.NioSocketImpl.bind(NioSocketImpl.java:643)
> > >                 at
> > > java.base/java.net.ServerSocket.bind(ServerSocket.java:395)
> > >                 at
> > > java.base/java.net.ServerSocket.<init>(ServerSocket.java:281)
> > >                 at
> > > org.apache.tomcat.util.net
> > > .TestXxxEndpoint.testStartStopBindOnInit(TestXxxEndpoint.java:150)
> > >                 at
> > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> > > Method)
> > >                 at
> > >
> > >
> >
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
> > >                 at
> > >
> > >
> >
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > >                 at
> > > java.base/java.lang.reflect.Method.invoke(Method.java:566)
> > >                 at
> > >
> > >
> >
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> > >                 at
> > >
> > >
> >
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > >                 at
> > >
> > >
> >
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> > >                 at
> > >
> > >
> >
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > >                 at
> > >
> > >
> >
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > >                 at
> > >
> >
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > >                 at
> > > org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> > >                 at
> > > org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> > >                 at
> > >
> > >
> >
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> > >                 at
> > > org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> > >                 at
> > >
> > >
> >
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> > >                 at
> > >
> > >
> >
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> > >                 at
> > > org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> > >                 at
> > > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> > >                 at
> > > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> > >                 at
> > > org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> > >                 at
> > > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> > >                 at
> > >
> > >
> >
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> > >                 at
> > >
> >
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> > >                 at
> > > org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> > >                 at
> > > org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> > >                 at
> > > junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:50)
> > >                 at
> > >
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:534)
> > >                 at
> > >
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1196)
> > >                 at
> > >
> > >
> >
> org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1041)
> > > 08-Feb-2021 08:38:15.839 INFO [main]
> > > org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3-39117"]
> > > 08-Feb-2021 08:38:15.839 INFO [main]
> > > org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3-39117"]
> > > 08-Feb-2021 08:38:15.845 INFO [main]
> > > org.apache.catalina.core.StandardService.stopInternal Stopping service
> > > [Tomcat]
> > > 08-Feb-2021 08:38:15.847 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log SessionListener:
> > > contextDestroyed()
> > > 08-Feb-2021 08:38:15.847 INFO [main]
> > > org.apache.catalina.core.ApplicationContext.log ContextListener:
> > > contextDestroyed()
> > > 08-Feb-2021 08:38:15.851 INFO [main]
> > > org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3-39117"]
> > > 08-Feb-2021 08:38:15.869 INFO [main]
> > > org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
> > > ["http-nio2-127.0.0.1-auto-3-39117"]
> > > ------------- ---------------- ---------------
> > >
> > > Testcase: testUnixDomainSocket took 1.841 sec
> > >         FAILED
> > > null
> > > junit.framework.AssertionFailedError
> > >         at
> > > org.apache.tomcat.util.net
> > > .TestXxxEndpoint.testUnixDomainSocket(TestXxxEndpoint.java:224)
> > >         at
> > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> > > Method)
> > >         at
> > >
> > >
> >
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
> > >         at
> > >
> > >
> >
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > >
> > > Testcase: testStartStopBindOnStart took 6.21 sec
> > > Testcase: testStartStopBindOnInit took 0.739 sec
> > >
> > > The test has been failing since Feb 19 (nightly build on my aarch64
> > > machine), i.e. since
> > >
> > >
> >
> https://github.com/apache/tomcat/commit/16e3ef43f2fd3aa4ac9dcf14a8e985ef0754022c
> > > .
> > > Sorry for not noticing it earlier!
> > >
> >
> > This works fine for me.
> >
>
> Are you sure that NIO2 works fo you ?
> Because Nio2Endpoint has no property/field 'unixDomainSocketPath' and
>
> https://github.com/apache/tomcat/blob/052ff33d95cb96958ff2af8371a32bbc563d9145/test/org/apache/tomcat/util/net/TestXxxEndpoint.java#L224
> should fail for you too.
>

Of course it worked, since I didn't test NIO2, I already knew UDS was not
supported ... The skip test check is now fixed.

Rémy


>
>
> >
> > Rémy
> >
> >
> > >
> > > Martin
> > >
> > > On Fri, Feb 5, 2021 at 1:12 PM Rory O'Donnell <
> rory.odonn...@oracle.com>
> > > wrote:
> > >
> > > >
> > > > *Hi Mark, *
> > > >
> > > > *Per the JDK 16 schedule , we are in the Release Candidate Phase**[1]
> > .*
> > > >
> > > > *Please advise if you find any issues while testing the latest Early
> > > > Access builds.*
> > > >
> > > >   * Schedule for JDK 16
> > > >       o *2021/02/04 Initial Release Candidate*
> > > >       o 2021/02/18 Final Release Candidate
> > > >       o 2021/03/16 General Availability
> > > >   * Release Notes [2]
> > > >
> > > > OpenJDK 16 Early Access build 35**is now available at
> > > > http://jdk.java.net/16 <http://jdk.java.net/16>
> > > >
> > > >   * These early-access, open-source builds are provided under the GNU
> > > >     General Public License, version 2, with the Classpath Exception
> > > >     <http://openjdk.java.net/legal/gplv2+ce.html>.
> > > >   * Features [3] - the overall feature set is frozen. No further JEPs
> > > >     will be targeted to this release.
> > > >   * Changes in recent builds that maybe of interest:
> > > >       o Build 34:
> > > >           + JDK-8259025: Record compact constructor using
> > > >             Objects.requireNonNull
> > > >               # Reported by JUnit5
> > > >       o Build 32:
> > > >           + JDK-8259014: Incomplete support for Unix domain sockets
> in
> > > >             Windows 2019 Server
> > > >
> > > >   * JDK 16 - topics of interest:
> > > >       o Unix domain socket channels (JEP-380) overview:
> > > >
> > > > https://inside.java/2021/02/03/jep380-unix-domain-sockets-channels/
> > > >         <
> > > > https://inside.java/2021/02/03/jep380-unix-domain-sockets-channels/>
> > > >       o Java Feature Spotlight: Pattern Matching
> > > >
> > > https://inside.java/2021/01/22/feature-spotlight-pattern-matching/
> > > >         <
> > > > https://inside.java/2021/01/22/feature-spotlight-pattern-matching/>
> > > >       o Foreign Memory Access - Pulling all the thread
> > > >
> > > >
> https://inside.java/2021/01/25/memory-access-pulling-all-the-threads/
> > > >         <
> > > >
> https://inside.java/2021/01/25/memory-access-pulling-all-the-threads/>
> > > >   * General – topic of interest:
> > > >       o Inside Java Episode 11 “How to contribute to OpenJDK” with
> > > >         Stuart Marks and Jesper Wilhelmsson
> > > >         https://inside.java/2021/01/29/podcast-011/
> > > >         <https://inside.java/2021/01/29/podcast-011/>
> > > >
> > > >
> > > > Project Lanai EA 9 Build 17-lanai+2-49 (2021/1/20)
> > > > <http://jdk.java.net/lanai/> is available now
> > > >
> > > >   * These early-access builds are provided under the GNU General
> Public
> > > >     License, version 2, with the Classpath Exception
> > > >     <http://openjdk.java.net/legal/gplv2+ce.html>
> > > >   * EA builds are intended for developers looking to test and provide
> > > >     feedback on using Project Lanai.
> > > >   * This is a macOS-specific project which implements a new Java 2D
> > > >     graphics rendering pipeline for macOS.
> > > >   * Project Lanai Wiki:
> > https://wiki.openjdk.java.net/display/lanai/Main
> > > >     <https://wiki.openjdk.java.net/display/lanai/Main>
> > > >   * Please send feedback via e-mail to lanai-...@openjdk.java.net
> > > >     <mailto:lanai-...@openjdk.java.net>. To send e-mail to this
> > address
> > > >     you must first subscribe to the mailing list
> > > >     <https://mail.openjdk.java.net/mailman/listinfo/lanai-dev>.
> > > >
> > > > Project Loom Build 17-loom+2-42 (2021/1/14) <
> http://jdk.java.net/loom/
> > >
> > > > based on JDK-17+5
> > > > <https://github.com/openjdk/jdk/releases/tag/jdk-17%2B5> is
> available
> > > now
> > > >
> > > >   * These early-access builds are provided under the GNU General
> Public
> > > >     License, version 2, with the Classpath Exception
> > > >     <http://openjdk.java.net/legal/gplv2+ce.html>
> > > >   * These builds are intended for developers looking to "kick the
> > tyres"
> > > >     and provide feedback on using the API or by sending bug reports.
> > > >   * API Javadoc :
> > > >     https://download.java.net/java/early_access/loom/docs/api/
> > > >     <https://download.java.net/java/early_access/loom/docs/api/>
> > > >   * Please send feedback via e-mail to loom-...@openjdk.java.net
> > > >     <mailto:loom-...@openjdk.java.net>. To send e-mail to this
> address
> > > >     you must first subscribe to the mailing list
> > > >     <http://mail.openjdk.java.net/mailman/listinfo/loom-dev>.
> > > >
> > > > OpenJDK 17 Early Access build 8**is now available at
> > > > http://jdk.java.net/17 <http://jdk.java.net/17>
> > > >
> > > >   * These early-access, open-source builds are provided under the GNU
> > > >     General Public License, version 2, with the Classpath Exception
> > > >     <http://openjdk.java.net/legal/gplv2+ce.html>.
> > > >   * Changes in recent builds that maybe of interest:
> > > >       o Build 8:
> > > >           + JDK-8222850: Misleading cascade compiler error in switch
> > > >             expression with undefined vars
> > > >               # Reported by jOOQ.
> > > >           + JDK-8217633: Configurable extensions with system
> properties
> > > >           + JDK-8249867: DOM LSSerializer control of newline after
> XML
> > > >             header
> > > >           + JDK-8256421: Added 2 HARICA Root CA Certificates
> > > >           + JDK-8259801: Enable XML Signature secure validation mode
> by
> > > >             default
> > > >       o Build 7:
> > > >           + JDK-8165276: Spec states to invoke the premain method in
> an
> > > >             agent class if it's public but implementation differs
> > > >           + JDK-8256895: Add support for RFC 8954: Online Certificate
> > > >             Status Protocol (OCSP) Nonce Extension
> > > >       o Build 6:
> > > >           + JDK-8259048: (tz) Upgrade time-zone data to tzdata2020f
> > > >
> > > > January 2021 Critical Patch Update Released:
> > > >
> > > >   * As part of the Jan 2021 CPU we released JDK 15.0.2, JDK 11.0.10
> > LTS,
> > > >     JDK 8u281, and JDK 7u291 as well as OpenJDK 15.0.2 (publicly
> > > > available).
> > > >
> > > > Rgds, Rory
> > > >
> > > > [1]
> > > >
> > >
> >
> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-February/005062.html
> > > > <
> > >
> >
> https://mail.openjdk.java.net/pipermail/jdk-dev/2021-February/005062.html
> > > > >
> > > > [2] https://jdk.java.net/16/release-notes
> > > > <https://jdk.java.net/16/release-notes>
> > > > [3] http://openjdk.java.net/projects/jdk/16/
> > > > <http://openjdk.java.net/projects/jdk/16/>
> > > >
> > > > --
> > > > Rgds, Rory O'Donnell
> > > > Quality Engineering Manager
> > > > Oracle EMEA, Dublin, Ireland
> > > >
> > > >
> > >
> >
>

Reply via email to