On 26/01/2021 14:15, Rémy Maucherat wrote: > On Tue, Jan 26, 2021 at 3:11 PM Mark Thomas <ma...@apache.org> wrote: > >> On 26/01/2021 14:06, Rémy Maucherat wrote: >>> On Tue, Jan 26, 2021 at 2:56 PM <ma...@apache.org> wrote: >>> >>>> This is an automated email from the ASF dual-hosted git repository. >>>> >>>> markt pushed a commit to branch 9.0.x >>>> in repository https://gitbox.apache.org/repos/asf/tomcat.git >>>> >>>> >>>> The following commit(s) were added to refs/heads/9.0.x by this push: >>>> new 9ebeda2 Fix a SpotBugs warning - log an message when >> permission >>>> setting fails >>>> 9ebeda2 is described below >>>> >>>> commit 9ebeda2df488803d61b371c0cc36db83fe04f197 >>>> Author: Mark Thomas <ma...@apache.org> >>>> AuthorDate: Tue Jan 26 13:54:52 2021 +0000 >>>> >>>> Fix a SpotBugs warning - log an message when permission setting >> fails >>>> >>> >>> Actually, the "else" seems useless at the moment and should be dropped >>> altogether. >> >> I can do that as I am in the area. Worth logging if attrs is null? >> > > The result cannot be null, it could only throw an exception. I didn't > translate the code for the PR very accurately, actually they wanted to set > the default permissions when getUnixDomainSocketPathPermissions() is null. > So we'll see later if that is really needed (I think the user could do it > since it could be sensitive).
OK. I'll clean it up on that basis. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
