On Tue, Jan 12, 2021 at 5:49 PM Romain Manni-Bucau <rmannibu...@gmail.com> wrote:
> Hi all, > > I suspect it is intended but if so I wonder if it needs some toggle to > disable that behavior: is the fact to not break when a listener (start) > fails intended? ([1]) > > An ASF friend hit that with 2 listeners and second one was failling after > first one failed because it was depending on it. > > Since this is not uncommon I wonder if it should get a break once ok=false > (issue can be listenerStop which should probably be independent of start > chain behavior since some listener only impl it) or if we should have a > flag in StandardContext to stop at first start failure. > > Anything already thought on it? > For all other subcomponents of the context, the behavior is: set ok to false, log the error and continue. It should stay that way. However, since a ServletContextListener is a Servlet API component, then the Servlet specification is supposed to resolve this one way or the other, but I don't think it does. In a similar case the language is "log and fail to deploy". As this is application related it could be reasonable to stop there. Rémy > > [1] > > https://github.com/apache/tomcat/blob/master/java/org/apache/catalina/core/StandardContext.java#L4669 > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > >
